c# - Procedure or function sp_select_companydetails has too many arguments specified -
i depressed error function code correct still giving me error, trying select information sql server database.
stored procedure:
create procedure sp_select_companydetails @id varchar(5) begin select company_name, company_address companydetails end
c# code:
2) on form button click event
string id = "1"; cmd.commandtype = commandtype.storedprocedure; cmd.commandtext = "sp_select_companydetails"; cmd.parameters.add("@id", id); filldataset();
in class
public dataset filldataset() { try { using (cmd) { dataset ds = new dataset(); cmd.connection = con; sqldataadapter da = new sqldataadapter(cmd); da.fill(ds); cmd.parameters.clear(); return ds; } } catch (exception) { throw; } }
when click on form button error:
procedure or function sp_select_companydetails has many arguments specified.
suggest me solution
thank in advance
instead of using global sqlcommand, create new everytime need it. recommended approach when deal disposable objects
using (sqlconnection con = new sqlconnection(getconnectionstring()) using (sqlcommand mycmd = new sqlcommand("sp_select_companydetails", con)) { cmd.commandtype = commandtype.storedprocedure; cmd.parameters.add("@id", sqldbtype.varchar).value = "1"; dataset ds = new dataset(); sqldataadapter da = new sqldataadapter(cmd); da.fill(ds); return ds; }
by way, cannot see how create sqlconnection, seems have disposable object kept @ global level. particular nasty sqlconnection because object keeps references system wide resources both on client , on server. not create global connection objects, create global method returns current connectionstring use in creation of local sqlconnection (the getconnectionstring()
in example above). if think performance killer suggest read the concept of connection pooling
Comments
Post a Comment